D24997: [Lock Screen] Don't use black shadows with black text

filipf updated this revision to Diff 68868. filipf added a comment. also apply the same fix to the login screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24997?vs=68867&id=68868 BRANCH black-text-no-black-shadow (branched from master) REVI

D24997: [Lock Screen] Don't use black shadows with black text

filipf added inline comments. INLINE COMMENTS > broulik wrote in LockScreenUi.qml:37 > Would it make more sense to use `hsvValue` or `hslLightness`? Maybe, I just copy pasted this from the wallpaper fader: https://github.com/KDE/plasma-workspace/blob/master/lookandfeel/contents/components/Wallp

D24997: [Lock Screen] Don't use black shadows with black text

broulik added inline comments. INLINE COMMENTS > LockScreenUi.qml:37 > readonly property bool softwareRendering: GraphicsInfo.api === > GraphicsInfo.Software > +readonly property bool lightBackground: > Math.max(PlasmaCore.ColorScope.backgroundColor.r, > PlasmaCore.ColorScope.backgrou

D24997: [Lock Screen] Don't use black shadows with black text

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY BUG: 413537 FIXED-IN: 5.17.2 REPOSITORY R120 Plasma Workspace BRANCH black-text-no-black-shadow (branched from master) REVISI