D25006: Checking dpi value being empty is not enought

2019-10-28 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > advancedconfig.cpp:193 > > if (!dpiValue.isEmpty()) { > + // minimal possible valid step from Force font DPI setings You can combine both of th

D25006: Checking dpi value being empty is not enought

2019-10-28 Thread Gabriel Craciunescu
gcraciunescu created this revision. gcraciunescu added a reviewer: filipf. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gcraciunescu requested review of this revision. REVISION SUMMARY We need to make sure the -dpi value is something valid. Right now we can pass eve