davidedmundson commandeered this revision.
davidedmundson added a reviewer: romangg.
davidedmundson added a comment.
Edit, it was done. Just not reuploaded and approved in the correct order.
Try to do that.
commandeering just to close
REPOSITORY
R104 KScreen
REVISION DETAIL
https:
davidedmundson reopened this revision.
davidedmundson added a comment.
You missed a review comment.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D25027
To: romangg, #plasma
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, fbampalou
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
romangg marked 3 inline comments as done.
Closed by commit R104:643e32c2bd2f: feat(kcm): zoom preview automatically
(authored by romangg).
C
davidedmundson added a comment.
Other that Nate's sensible comment, +1
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D25027
To: romangg, #plasma
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,
ngraham added inline comments.
INLINE COMMENTS
> romangg wrote in Screen.qml:67
> Yea, I ignore the row for now. We can think about a different position for
> the button later on. I think it should be in one of the corners like it used
> to be.
Why not remove the Row in this revision? You don'
romangg added inline comments.
INLINE COMMENTS
> ngraham wrote in Screen.qml:67
> You don't need a Row here anymore because it now only contains one item;
> instead you can just position the Identify button manually.
Yea, I ignore the row for now. We can think about a different position for the
ngraham added inline comments.
INLINE COMMENTS
> Screen.qml:67
>
> Row {
> z: 90
You don't need a Row here anymore because it now only contains one item;
instead you can just position the Identify button manually.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator
romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.
REVISION SUMMARY
On output size and position changes reset the relative output position in the
overview automatic
