D25413: [Weather] Make compact representation temperature text match size of clock text

This revision was automatically updated to reflect the committed changes. Closed by commit R114:edb1367acc39: [Weather] Make compact representation temperature text match size of clock text (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25413: [Weather] Make compact representation temperature text match size of clock text

ngraham added a comment. Can you formally accept, maybe? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25413 To: ngraham, #vdg, #plasma Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D25413: [Weather] Make compact representation temperature text match size of clock text

spstarr added a comment. as for the change, it looks good to me.. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25413 To: ngraham, #vdg, #plasma Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25413: [Weather] Make compact representation temperature text match size of clock text

spstarr added a comment. Probably could also say the same for, winds/visibility those could be rounded in some places depending on the unit(s). REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25413 To: ngraham, #vdg, #plasma Cc: spstarr, filipf, plasma-devel,

D25413: [Weather] Make compact representation temperature text match size of clock text

ngraham added a comment. In D25413#565258 , @spstarr wrote: > I wonder, some users might not want to see the temperature decimal points, maybe an option to hide it? The reason I exposed that level of temperature in the engine was when you live

D25413: [Weather] Make compact representation temperature text match size of clock text

spstarr added a comment. I wonder, some users might not want to see the temperature decimal points, maybe an option to hide it? The reason I exposed that level of temperature in the engine was when you live in cold climates the exact decimal temperature might help to tell you if there was

D25413: [Weather] Make compact representation temperature text match size of clock text

ngraham added a comment. Sure, if and when this lands, I'll add that note to the applicable place in the code for the Digital Clock. And then we can plan out how to turn this into a constant that lives somewhere else. REPOSITORY R114 Plasma Addons REVISION DETAIL

D25413: [Weather] Make compact representation temperature text match size of clock text

filipf added a comment. > and I should feel bad. :D +1. It might also be useful to add a little reminder in the digital clock's code that the magic numbers are also used here if someone wants to change digital clock. REPOSITORY R114 Plasma Addons REVISION DETAIL

D25413: [Weather] Make compact representation temperature text match size of clock text

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, the Weather widget's compact representation's temperature text is not the same