D25415: Improve package documentation

2019-11-21 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R123:1efecc9608cc: Improve package documentation (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25415?vs=70130&id=70131 REV

D25415: Improve package documentation

2019-11-21 Thread Filip Fila
filipf updated this revision to Diff 70130. filipf added a comment. minor indentation fix REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25415?vs=70082&id=70130 BRANCH better-documentation (branched from master) REVISION DETAIL

D25415: Improve package documentation

2019-11-20 Thread Filip Fila
filipf updated this revision to Diff 70082. filipf added a comment. simpler dependencies list REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25415?vs=70020&id=70082 BRANCH better-documentation (branched from master) REVISION DETAI

D25415: Improve package documentation

2019-11-20 Thread David Edmundson
davidedmundson added a comment. > The list would probably get outdated soon and maybe the deps can be listed more abstractly so there's fewer lines. Yeah. Also this looks like the output of running cmake anyway, so I don't see what we gain by writing it in another place. REPOSITORY R1

D25415: Improve package documentation

2019-11-20 Thread Filip Fila
filipf added a comment. Maybe I shouldn't list all those dependencies like that. The list would probably get outdated soon and maybe the deps can be listed more abstractly so there's fewer lines. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH better-documentation (branched from m

D25415: Improve package documentation

2019-11-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH better-documentation (branched from master) REVISION DETAIL https://phabricator.kde.org/D25415 To: filipf, #plasma, #vd

D25415: Improve package documentation

2019-11-19 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The old readme file was just 4 outdated lines on how to compile the package.. I've now tried to add all the crucial info and writ