D25428: Improved support for desktop "Folder View"

steffenh added a comment. New version of the patch is here: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/170 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To:

D25428: Improved support for desktop "Folder View"

ngraham added a comment. Awesome! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,

D25428: Improved support for desktop "Folder View"

steffenh added a comment. I'm working on another version of this patch at the moment. The new version doesn't need a MouseArea in the FolderItemDelegate. If the new patch is ready, I will make a merge request on GitLab. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25428: Improved support for desktop "Folder View"

The-Feren-OS-Dev added a comment. bump! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, cblack, jraleigh,

D25428: Improved support for desktop "Folder View"

The-Feren-OS-Dev added a comment. Any update on the status of this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage,

D25428: Improved support for desktop "Folder View"

cfeck added a comment. Anyone else able to review this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D25428: Improved support for desktop "Folder View"

hein added a comment. Just a quick note I will review this tomorrow or next week when I'm on vacation, sorry for the long wait. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: mart, ngraham, nicolasfella,

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 71583. steffenh added a comment. remove debug messages REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=71052=71583 BRANCH arcpatch-D25428 REVISION DETAIL https://phabricator.kde.org/D25428

D25428: Improved support for desktop "Folder View"

steffenh added a comment. I was trying to use the TapHandler, but I came across a problem with DragAndDrop that I need help with. If I try a DragAndDrop with touch the following happens: - I get a drag cursor, but i get no drag icon - if I release the touch the drag don`t end, I

D25428: Improved support for desktop "Folder View"

ngraham added a comment. Does `grabChanged` work? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: mart, ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25428: Improved support for desktop "Folder View"

ngraham added a comment. In D25428#574844 , @steffenh wrote: > and second we need to change QtQuick from 2.8 to 2.12. That's fine. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh,

D25428: Improved support for desktop "Folder View"

steffenh added a comment. Ok a quick look at TapHandler, first I am missing a positionChanged signal in the TapHandler and second we need to change QtQuick from 2.8 to 2.12. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein,

D25428: Improved support for desktop "Folder View"

mart added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:213 > + > +MouseArea { > +id: mousearea How much of this can be done with pointer handlers? https://doc.qt.io/qt-5/qml-qtquick-taphandler.html quickly looking at this mousearea it seems that

D25428: Improved support for desktop "Folder View"

steffenh added a comment. Hi @ngraham, That's a good news. I will make a new patch in the next days, without the debug messages. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: mart, ngraham,

D25428: Improved support for desktop "Folder View"

ngraham accepted this revision. ngraham added a reviewer: mart. ngraham added 1 blocking reviewer(s): hein. ngraham added a subscriber: mart. ngraham added a comment. Yay, it works perfectly for me now! This patch has become quite large so I'd definitely like @hein's input before it lands

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 71052. steffenh added a comment. get ride of all simulated mouse clicks change behavior for touch (similar to touch in kickoff): - access to the context menu after tapandhold and release touch - drag and drop after tabandhold and moving

D25428: Improved support for desktop "Folder View"

ngraham added a comment. Good luck! Thanks for working on this, it's really important. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25428: Improved support for desktop "Folder View"

steffenh added a comment. Hi @ngraham, thanks for testing, OK, I will rewrite this and see if I can get rid of all the simulated mouse clicks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham Cc: ngraham,

D25428: Improved support for desktop "Folder View"

ngraham added a comment. I'm afraid it's still not consistently fixed for me when using double-click. Most of the time, a tap will still select and then immediately de-select the item. Only about 1/4 of my taps actually open the item. With single-click, about 3/4 open the item, but the rest

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70597. steffenh added a comment. don't use simulated double mouse click to open/launch an item. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70247=70597 BRANCH arcpatch-D25428 REVISION DETAIL

D25428: Improved support for desktop "Folder View"

ngraham added a comment. Instead of emulating a double-click, can we instead always launch on a single-click with touch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham Cc: ngraham, nicolasfella, plasma-devel,

D25428: Improved support for desktop "Folder View"

steffenh added a comment. @ngraham thanks again for testing, Ok, so it's just the double click simulation was is not working 100% on your laptop, I think I can work with it. On the other hand, if I am lucky I can borrow a HPSpectre x360 in the next days, too test this directly.

D25428: Improved support for desktop "Folder View"

ngraham added a comment. I'm using an HP Spectre x360 convertible laptop with a touchscreen. Test results using the systemwide double-click setting: - With your patch: result is inconsistent: very occasionally, the item opens. Other times, the item becomes selected and then

D25428: Improved support for desktop "Folder View"

steffenh added a comment. First, thank for testing @nicolasfella and @ngraham Ok, now I am clueless. @ngraham maybe you can tell me, witch tablet and software version you used? If you have time, perhaps you can make a test without my patch. Move the cursor with the mouse

D25428: Improved support for desktop "Folder View"

ngraham added a comment. No change for me, sorry. :( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70247. steffenh added a comment. simulate left mouse click, if touchtap ended REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70078=70247 BRANCH folderview REVISION DETAIL

D25428: Improved support for desktop "Folder View"

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks! However this does not work 100% for me with my laptop's touchscreen. Touch-and-drag works to move items, and touch-and-hold works to show the context menu, but I cannot

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70078. steffenh added a comment. oops was wrong diff, now is it the correct version REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70066=70078 BRANCH touchFolderView REVISION DETAIL

D25428: Improved support for desktop "Folder View"

steffenh created this revision. steffenh added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. steffenh requested review of this revision. REVISION SUMMARY moving icon's on the desktop around with touch open/launch icons with tap (only singe tap,