D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham abandoned this revision. ngraham added a comment. Moved over to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/427. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc:

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

justinzobel added a comment. Can we please continue this over on Gitlab? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: justinzobel, mmustac, davidedmundson, astippich, plasma-devel,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. Hmm, in this case it doesn't seem appropriate to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: mmustac, davidedmundson, astippich, plasma-devel, hurikhan77,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

mmustac added a comment. Wouldn't it look better to use the new header/title component for the list view ? F8099139: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. That turned out to be an unrelated Baloo bug that was recently fixed by D27326 . This is ready for re-review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 75508. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=73775=75508 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVISION DETAIL

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham marked an inline comment as done. ngraham added a comment. Re-added the namespace but the state checking still doesn't seem to work properly. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 73775. ngraham added a comment. Re-add namespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=73771=73775 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:81 > Edit, no it wasn't wrong > > But I have found what is. > > I export this as the class Baloo, but the import is also under Baloo > > So for this to work against my patch it would be

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 73771. ngraham added a comment. Adjust to changes in D25743 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=73768=73771 BRANCH

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 73768. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=71013=73768 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVISION DETAIL

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added a comment. > Done, but now opening the KCM prints a ton of these errors: Is this still an issue? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: davidedmundson,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. @davidedmundson ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, The-Feren-OS-Dev,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:93 > Monitor's property is called state. Lowercase S. > > A switch statement here might make this a bit easier to read. Done, but now opening the KCM prints a ton of these errors: QMetaProperty::read: Unable

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 71013. ngraham added a comment. Address review comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70998=71013 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:93 > +// FIXME: this doesn't work; it's always invisible > +visible: (monitor.State == Baloo.Baloo.FirstRun || > +monitor.State == Baloo.Baloo.NewFiles || Monitor's

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. Thanks @davidedmundson. There's one more `FIXME` in the code that I could use your help with, if you don't mind. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc:

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70998. ngraham marked 2 inline comments as done. ngraham added a comment. Adjust to D25743 some more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70990=70998

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:81 > This is the wrong way round Edit, no it wasn't wrong But I have found what is. I export this as the class Baloo, but the import is also under Baloo So for this to work against my patch it would be

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:81 > +id: toggleButton > +text: monitor.state == Baloo.Suspended ? i18n("Resume") : > i18n("Suspend") > +onClicked: monitor.toggleSuspendState() This is the wrong way round

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70990. ngraham added a comment. Update to work with D25743 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70904=70990 BRANCH

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ngraham wrote in constants.js:23 > I'm not sure exactly what that means or how to do it; can you help me with it? See D25743

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in constants.js:23 > Why doesn't this come from the plugin? I'm not sure exactly what that means or how to do it; can you help me with it? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70904. ngraham marked an inline comment as done. ngraham added a comment. ALso check for LowPowerIdle state REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70859=70904 BRANCH

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:93 > + > +visible: fileSearchEnabled.checked && monitor.state != > Constants.State.Idle > + what about: LowPowerIdle? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To:

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70859. ngraham marked an inline comment as done. ngraham added a comment. Correct string error REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70858=70859 BRANCH

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70858. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70119=70858 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVISION DETAIL

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > constants.js:23 > + > +var State = { > +Idle: 0, Why doesn't this come from the plugin? > main.qml:111 > +if (monitor.state == Constants.State.ContentIndexing) { > +return i18n("Currently

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. In D25447#566622 , @astippich wrote: > For the concept a big +1 from me. I did not even know that we had that in the infocenter... I think most people don't know this, because it's an odd place to have controls

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

astippich added a comment. For the concept a big +1 from me. I did not even know that we had that in the infocenter... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns Cc: astippich, plasma-devel, hurikhan77,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham created this revision. ngraham added reviewers: VDG, Plasma, Baloo, bruns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Most of this code is lifted straight from the file indexing monitor