D25459: fix(kcm): improve i18n of device combobox

romangg added subscribers: broulik, romangg. romangg added a comment. Thanks for the patch. @broulik: since you changed it last iirc is this good to go? Since it's a string change only master? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25459 To: guoyunhe, kde-i

D25459: fix(kcm): improve i18n of device combobox

guoyunhe added a comment. Should we reassign a reviewer? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25459 To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouk

D25459: fix(kcm): improve i18n of device combobox

romangg added a comment. In D25459#572452 , @guoyunhe wrote: > Should we reassign a reviewer? No, let me test it later today. But since it's a string change it can only go in master. If the translation team gives permission though it can

D25459: fix(kcm): improve i18n of device combobox

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. With this change controls are not aligned anymore in English language: F7802717: Screenshot_20191206_211348.png Did you test it?

D25459: fix(kcm): improve i18n of device combobox

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Ignore my previous comment. I thought it was aligned before. But it wasn't aligned there either. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/

D25459: fix(kcm): improve i18n of device combobox

guoyunhe added a comment. It seems impossible to align them if they are not in one QML file. `twinFormLayouts` can only refer ids of current context. This happens in several different KCMs. Would be great to have a solution for global alignment. But I think that need some changes to Kirigami

D25459: fix(kcm): improve i18n of device combobox

This revision was automatically updated to reflect the committed changes. Closed by commit R104:3b10f0da5aa9: fix(kcm): improve i18n of device combobox (authored by Guo Yunhe ). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25459?vs=70151&id