This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b2383cc77f6: KCM launch feedback : take into account
immutable properties (authored by crossi).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25526?vs=7030
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.
Indeed much better with Kai's suggestion.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25526
To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: br
crossi added inline comments.
INLINE COMMENTS
> broulik wrote in main.qml:45
> Imho this is confusing.
> The property should be `readonly property bool cursorImmutable:
> kcm.setings.immutable && ..` and then this would be `enabled: !immutable`
Thanks for pointing this.
Reworked the property t
crossi updated this revision to Diff 70304.
crossi added a comment.
Make the propery readonly, boolean condition to repeat the same pattern
enabled: !immutable
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25526?vs=70300&id=70304
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> main.qml:45
>
> +enabled: formLayout.cursorImmutable
> Kirigami.FormData.label: i18n("Cursor:")
Imho this is confusing.
The property should be `readonly property bool cursorImmutable:
kcm.setings.immutable && ..` and th
crossi updated this revision to Diff 70300.
crossi added a comment.
blank line
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25526?vs=70298&id=70300
REVISION DETAIL
https://phabricator.kde.org/D25526
AFFECTED FILES
kcms/launch/package/contents
crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25526
AFFECTED FILES
kcms/launch/package/contents/ui/main.qml
To: cr
