D25539: KScreen KCM: Add a revert timer to the settings page

romangg added a comment. Do we want a revert timer or not? I thought about this in the past and have not yet come to a definite conclusion. Other question is how this relates to "instant-apply". Do we want this as well in the future? Interesting would be the reasoning in the past to have

D25539: KScreen KCM: Add a revert timer to the settings page

ngraham added a reviewer: romangg. ngraham added a comment. Yeah, it would be good to know the history on that. Also, please change the title to "feat(kcm): add a revert timer to the settings page" to comply with KScreen's new commit message guidelines. INLINE COMMENTS > main.qml:32 >

D25539: KScreen KCM: Add a revert timer to the settings page

ndavis added a comment. In D25539#567576 , @broulik wrote: > One of the key ideas of KScreen was that it will *not* have a revert timer. Could you expand on that? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D2

D25539: KScreen KCM: Add a revert timer to the settings page

broulik added a comment. One of the key ideas of KScreen was that it will *not* have a revert timer. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma Cc: broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalou

D25539: KScreen KCM: Add a revert timer to the settings page

liushuyu updated this revision to Diff 70329. liushuyu added a comment. Fix the diff REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70328&id=70329 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25539 AFFECTED FILES kcm/config_h

D25539: KScreen KCM: Add a revert timer to the settings page

ndavis added a comment. +1 for this safety feature It would be nice to have a visible countdown timer though. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalo

D25539: KScreen KCM: Add a revert timer to the settings page

liushuyu created this revision. liushuyu added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. liushuyu requested review of this revision. REVISION SUMMARY Add a revert timer and an option for the user to revert the settings when they accidentally messe