D25614: [System Tray] Clean up popup code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:beac5919274c: [System Tray] Clean up popup code (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25614?vs=70748&id=70762 REVISION DETA

D25614: [System Tray] Clean up popup code

filipf updated this revision to Diff 70748. filipf added a comment. onToggled instead of onClicked REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25614?vs=70577&id=70748 BRANCH code-cleanup (branched from master) REVISION DETAIL https://phabr

D25614: [System Tray] Clean up popup code

broulik added inline comments. INLINE COMMENTS > filipf wrote in ExpandedRepresentation.qml:103 > @broulik? Both are fine I guess but `onToggled` is indeed more correct REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25614 To: filipf, #plasma, broulik Cc: ngr

D25614: [System Tray] Clean up popup code

filipf added inline comments. INLINE COMMENTS > ngraham wrote in ExpandedRepresentation.qml:103 > `onToggled`? @broulik? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25614 To: filipf, #plasma, broulik Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Fere

D25614: [System Tray] Clean up popup code

ngraham added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:103 > checked: plasmoid.configuration.pin > -onCheckedChanged: plasmoid.configuration.pin = checked > +onClicked: plasmoid.configuration.pin = checked > icon.name: "window

D25614: [System Tray] Clean up popup code

filipf added a comment. Everything looks the same, but I did notice that the "Status and Notifications" isn't on the right in RTL mode, not sure why: F7789933: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D25614: [System Tray] Clean up popup code

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This removes hacks and does things in a cleaner way. Credits go to @broulik. REPOSITORY R120 Plasma Workspace BRANCH code-c