D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf updated this revision to Diff 80582. filipf added a comment. remove the separator instead of just shortening it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25728?vs=70873=80582 BRANCH no-unwanted-titlebar-separator (branched from

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. Yeah. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. I guess the top separator should be removed altogether then? (As opposed to just shortening it) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a subscriber: cblack. ngraham added a comment. In D25728#640365 , @ngraham wrote: > With D27669 , it's probably time to revisit drawing this separator at all. We should probably be relying on the

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#576703 , @ngraham wrote: > Maybe what we should do is change the titlebar separator color in Breeze to be a pleasant dark gray like in the screenshot in @flipwise's latest comment instead of a garish blue, turn

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

Codezela added a comment. In D25728#572044 , @filipf wrote: > In D25728#572043 , @anthonyfieroni wrote: > > > So with the patch is it drawn when it is ticked in window decoration? > > > Yes.

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. With D27669 , it's probably time to revisit drawing this separator at all. We should probably be relying on the widget and/or decoration style to do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. In D25728#572362 , @manueljlin wrote: > I though that would just affect every app's titlebar without actually checking if the app has a toolbar, etc etc and just add/remove the divider everywhere and be done with it.

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

manueljlin added a comment. I though that would just affect every app's titlebar without actually checking if the app has a toolbar, etc etc and just add/remove the divider everywhere and be done with it. However, if the app can actually send a hint to Kwin to make it hide or show the

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#572350 , @manueljlin wrote: > But that style of line / divider was going to be after the toolbars too, like kirigami apps, so removing it just would make that inconsistent later on. The divider needs to be

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

manueljlin added a comment. But that style of line / divider was going to be after the toolbars too, like kirigami apps, so removing it just would make that inconsistent later on. If it's possible, fixing the color scheme and making it configurable should probably be the way to go.

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#572043 , @anthonyfieroni wrote: > So with the patch is it drawn when it is ticked in window decoration? Yes. With the patch there is only a top separator on the sidebar, not between the titlebar and

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. So with the patch is it drawn when it is ticked in window decoration? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#572036 , @anthonyfieroni wrote: > Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ? No, the separator is always drawn. REPOSITORY R119 Plasma Desktop

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#571848 , @ngraham wrote: > But... the "Before" image looks better. :/ > > Having the titlebar blend with the window kind of requires that nothing wants to be touching the titlebar, or else it just looks bad

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

broulik added a comment. I never noticed that line before but now that I did, I can't unsee it. It looks quite bad with dark Breeze title bar, where it is quite superfluous. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc:

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. But... the "Before" image looks better. :/ Having the titlebar blend with the window kind of requires that nothing wants to be touching the titlebar, or else it just looks bad IMO. Personally my preference is to restore consistency by moving in the opposite

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY I added a top separator for QML applet configuration windows in D20908 This separator is