This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4bdbd44facf0: Make startplasma more flexible so it can be
leveraged by plasma mobile (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D25750?vs=70920&id=70951#toc
REPOSITORY
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> bshah wrote in main.cpp:93
> On second thought, scratch all this.
For completion, this was already doable as is.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
broulik added inline comments.
INLINE COMMENTS
> startplasma-wayland.cpp:88
> +args.reserve(argc);
> +for(int i=1; i +args << QString::fromLocal8Bit(argv[i]);
Coding style, please.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabric
alexeymin added inline comments.
INLINE COMMENTS
> apol wrote in startplasma-wayland.cpp:91
> Please see
> https://invent.kde.org/kde/plasma-phone-components/merge_requests/38
Indeed, I overlooked, probably lack of `{ }` around `for` loop confused me..
REPOSITORY
R120 Plasma Workspace
BRANC
bshah accepted this revision.
bshah added inline comments.
INLINE COMMENTS
> bshah wrote in main.cpp:93
> I am bit unsure about this. We can simply write a configuration file in
> /etc/xdg using the plasma-phone-settings package.
On second thought, scratch all this.
REPOSITORY
R120 Plasma Wo
bshah added inline comments.
INLINE COMMENTS
> main.cpp:93
> KConfigGroup startupConfGroup(startupConf, "Shell");
> -const QString defaultShell = startupConfGroup.readEntry("ShellPackage",
> "org.kde.plasma.desktop");
> +const QString defaultShell = startupConfGroup.readEntry("Shell
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> alexeymin wrote in startplasma-wayland.cpp:91
> Currently I can edit simple shell script (kwinwrapper) and remove the
> argument to kwin_wayland. If this is going to be hardcoded in the executable,
> it cannot
mart accepted this revision as: mart.
mart added a comment.
This revision is now accepted and ready to land.
+1 from me, would still like other opinions
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25750
To: apol, #plasma, bshah, mart
Cc:
alexeymin added inline comments.
INLINE COMMENTS
> apol wrote in startplasma-wayland.cpp:91
> This is not changing, --xwayland is already on by default. In fact it will be
> possible to change the defaults by passing some arguments to
> startplasma-wayland.
Currently I can edit simple shell sc
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> alexeymin wrote in startplasma-wayland.cpp:91
> having `--xwayland` always by default will unfortunately break my device port
> (xwayland crashes for me for some reason)
This is not changing, --xwayland is alre
alexeymin added inline comments.
INLINE COMMENTS
> startplasma-wayland.cpp:91
> +} else {
> +args = QStringList { QStringLiteral("--xwayland"),
> QStringLiteral("--libinput"), QStringLiteral("--exit-with-session="
> CMAKE_INSTALL_FULL_LIBEXECDIR "/startplasma-waylandsession") };
> +
alexeymin added a comment.
Good to see more flexibility!
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25750
To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himces
apol created this revision.
apol added reviewers: Plasma, bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Allows specifying the shell through an environment variable.
Allows forwarding command line argumen
13 matches
Mail list logo
