D25782: [Notifications] Add draggable file icon when single file job finishes

2019-12-18 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:a22c44dafc6b: [Notifications] Add draggable file icon when single file job finishes (authored by broulik). CHANGED PRI

D25782: [Notifications] Add draggable file icon when single file job finishes

2019-12-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ngraham wrote in notificationapplet.h:73 > maybe use one of the standard sizes instead of a hardcoded int? That's the default, there's a `Binding` to `units.iconSizes.large` in `main.qml` REPOSITORY R120 Plasma Workspace REVISION DETAIL http

D25782: [Notifications] Add draggable file icon when single file job finishes

2019-12-06 Thread Nathaniel Graham
ngraham added a comment. Awesome, this is super-dee-duper useful! +1! INLINE COMMENTS > notificationapplet.h:73 > bool m_dragActive = false; > +int m_dragPixmapSize = 64; > maybe use one of the standard sizes instead of a hardcoded int? REPOSITORY R120 Plasma Workspace REVISIO

D25782: [Notifications] Add draggable file icon when single file job finishes

2019-12-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a file icon to a finished job for a single total file which can be dragged anywhere