D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 72336. ngraham added a comment. Implement VDG mockups REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72312&id=72336 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL ht

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. Review summary area: F7847927: discover-review_summary_area.svg.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_software_store Cc: ndavis, pla

D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 72312. ngraham added a comment. Rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=71290&id=72312 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL https://phabricat

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. In D25889#584040 , @apol wrote: > I'm not convinced about using emoji in place of icons. Are we sure about that? > > I like ndavis's suggestion, but as a delegate, having so many lines could look cluttered. > > Sh

D25889: Polish the "review this review" UI and presentation

apol added a comment. I'm not convinced about using emoji in place of icons. Are we sure about that? I like ndavis's suggestion, but as a delegate, having so many lines could look cluttered. Should we consider using cards? REPOSITORY R134 Discover Software Store REVISION DETAIL

D25889: Polish the "review this review" UI and presentation

ngraham planned changes to this revision. ngraham added a comment. In D25889#583707 , @ndavis wrote: > Here's a suggestion for a way to improve the UI: F7846171: Screenshot_20191227_195713.png That l

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. Another thing to consider is whether or not the review section in Discover should be kept consistent with the reviews/comments in the new GHNS UI. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol,

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. In D25889#577558 , @ngraham wrote: > I find that the current one takes up too much vertical space and the top line of text blends too much into the review itself. I feel like those issues should be addressed somehow. Mayb

D25889: Polish the "review this review" UI and presentation

ngraham added a comment. Ping. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_software_store Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngra

D25889: Polish the "review this review" UI and presentation

ngraham added a comment. I find that the current one takes up too much vertical space and the top line of text blends too much into the review itself. I feel like those issues should be addressed somehow. Maybe this isn't the right way, so suggestions would be appreciated. REPOSITORY R134

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. I don't find this better than the current form: F7817345: Screenshot_20191214_002245.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_softwar

D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 71290. ngraham added a comment. Fix the rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=71287&id=71290 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL https://p

D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 71287. ngraham added a comment. Rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=71284&id=71287 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL https://phabricat

D25889: Polish the "review this review" UI and presentation

ngraham created this revision. ngraham added reviewers: VDG, apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now with 100% more Emojis! And the UI doesn't blend into the actual rev