D25942: Instead of just delaying, compress calls to update

2019-12-13 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. It was quite wrong REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25942 To: apol, #kirigami Cc: mart, ngraham, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson,

D25942: Instead of just delaying, compress calls to update

2019-12-13 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:106 > +id: delayUpdate > +interval: 200 > +onTriggered: update() i suppose if the delay is 0 it starts to jump again? > broulik wrote in ActionToolBarLayoutDetails.qml:110 > How can this even

D25942: Instead of just delaying, compress calls to update

2019-12-13 Thread Nathaniel Graham
ngraham added a comment. This does not actually fix the vibrating label for me. It's still going, as fast as ever: F7816236: Peek 2019-12-13 10-59.gif REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25942 To: apol, #kirigami

D25942: Instead of just delaying, compress calls to update

2019-12-13 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:110 > + > +onWidthChanged: { delayUpdate.start = true } > +Component.onCompleted: { delayUpdate.start = true } How can this even work? `start` is a method. You probably meant `running = true`? or `start()`

D25942: Instead of just delaying, compress calls to update

2019-12-13 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Fixes an issue I was seeing where the size kept changing between updates. TEST PLAN Now the