This revision was automatically updated to reflect the committed changes.
Closed by commit R169:3bc41934f9d6: Don't build and install app templates
on android (authored by jbbgameich).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25989?vs=71517&id=71518
RE
jbbgameich updated this revision to Diff 71517.
jbbgameich added a comment.
Follow suggestion
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25989?vs=71516&id=71517
BRANCH
android-no-app-templates (branched from master)
REVISION DETAIL
https://phabri
nicolasfella added inline comments.
INLINE COMMENTS
> CMakeLists.txt:123
> add_subdirectory(src)
> -add_subdirectory(templates)
> +if (NOT CMAKE_SYSTEM_NAME STREQUAL "Android")
> +add_subdirectory(templates)
if(ANDROID) is enough
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabri
nicolasfella added inline comments.
INLINE COMMENTS
> nicolasfella wrote in CMakeLists.txt:123
> if(ANDROID) is enough
if (NOT ANDROID) obviously
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D25989
To: jbbgameich, #kirigami, #android
Cc: nicolasfella, plasma-devel,
jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
They increase apk sizes and are really not required in an apk.
REPOSITORY
R169 Kirigami
BRANCH
android-no-app-template
