D25992: [Wizard] Allow choosing device by double click

2019-12-18 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R97:0fd34f0497cc: [Wizard] Allow choosing device by double click (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25992?vs=71525&id=71770 REVISION

D25992: [Wizard] Allow choosing device by double click

2019-12-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. True enough. This is for sure a nice improvement. I always appreciate it when double-click is a shortcut for "select this thing and the open/apply it." REPOSITORY R97 Bluedevil REVISIO

D25992: [Wizard] Allow choosing device by double click

2019-12-14 Thread Kai Uwe Broulik
broulik added a comment. I think you can't. It is potentially a long list, so not sure if just clicking it should advance the list, since it is clearly a "wizard" pattern page. If it were a bunch of "command links" it would be obvious that clicking a single item would advance the wizard. RE

D25992: [Wizard] Allow choosing device by double click

2019-12-14 Thread Nathaniel Graham
ngraham added a comment. Is there anything you can do with an item here other than selecting it? If not, then we should just always choose by single-click. Double-click only makes sense for items that have a distinct selection state that lets you do more things with the item (or when using t

D25992: [Wizard] Allow choosing device by double click

2019-12-14 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, drosca, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of having to select one and clicking "Next" TEST PLAN Clicked New device, d