D26012: Restore circular progress bar in compact notification applet

2019-12-15 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R120:da86d1e40a1d: Restore circular progress bar in compact notification applet (authored by ahiemstra). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26012?vs

D26012: Restore circular progress bar in compact notification applet

2019-12-15 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Lovely! REPOSITORY R120 Plasma Workspace BRANCH circular_progress REVISION DETAIL https://phabricator.kde.org/D26012 To: ahiemstra, #plasma, broulik Cc: broulik, plasma-devel, LeG

D26012: Restore circular progress bar in compact notification applet

2019-12-15 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 71584. ahiemstra added a comment. - Don't show busyindicator when there are no jobs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26012?vs=71579&id=71584 BRANCH circular_progress REVISION DETAIL https:

D26012: Restore circular progress bar in compact notification applet

2019-12-15 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 71579. ahiemstra added a comment. - Use visible to hide the busyindicator when progress > 0 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26012?vs=71577&id=71579 BRANCH circular_progress REVISION DETAIL

D26012: Restore circular progress bar in compact notification applet

2019-12-15 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CompactRepresentation.qml:103 > running: visible > +opacity: compactRoot.jobsPercentage == 0 ? 1 : 0 > } You might want to

D26012: Restore circular progress bar in compact notification applet

2019-12-15 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY During the port to Qt5 the circular progress bar was lost, since there is no simple way to