D26021: Display sub categories when searching

This revision was automatically updated to reflect the committed changes. Closed by commit R124:f82cca0cb07f: Display sub categories when searching (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71889&id=71890 REVISION DET

D26021: Display sub categories when searching

mart updated this revision to Diff 71889. mart added a comment. - root categories are 0 depth REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71881&id=71889 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021 AFF

D26021: Display sub categories when searching

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in MenuModel.cpp:49 > In other models we tend to drop the suffix "Role" from the rolename > > i.e Qt::DisplayRole -> "display" > > but it's not super important. I followed what it was doing previously, MenuItemRols->MenuItem wo

D26021: Display sub categories when searching

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > MenuModel.cpp:49 > > +QHash MenuModel::roleNames() const > +{ In other models we tend to drop the suffix "Role" from the rolename i.e Qt::DisplayRole

D26021: Display sub categories when searching

mart updated this revision to Diff 71881. mart added a comment. - remove trailing space REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71880&id=71881 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021 AFFECTED

D26021: Display sub categories when searching

mart updated this revision to Diff 71880. mart added a comment. - switch column when there are two REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71876&id=71880 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021

D26021: Display sub categories when searching

mart updated this revision to Diff 71876. mart added a comment. - don't accept invalid index as root - select proper category when not in search more REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71803&id=71876 BRANCH arcpatch-D26021

D26021: Display sub categories when searching

mart updated this revision to Diff 71803. mart added a comment. - Pleased code enter the commit message for your changes. Lines starting REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71799&id=71803 BRANCH arcpatch-D26021 REVISION DETAI

D26021: Display sub categories when searching

ngraham added inline comments. INLINE COMMENTS > MenuModel.cpp:25 > #include > - > +#include > #include "MenuItem.h" Remove > CategoriesPage.qml:149 > +//icon: model.decoration > +//label: model.display > separatorVisible: false Remove REPOSITORY R12

D26021: Display sub categories when searching

mart added a comment. In D26021#579771 , @ngraham wrote: > Nice! > > Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png > > It used to be white

D26021: Display sub categories when searching

mart updated this revision to Diff 71799. mart added a comment. - white text when selected - lways load the module when in search mode REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71776&id=71799 BRANCH arcpatch-D26021 REVISION DETAI

D26021: Display sub categories when searching

mart added a comment. In D26021#579771 , @ngraham wrote: > Nice! > > Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png > > It used to be white

D26021: Display sub categories when searching

ngraham added a comment. Nice! Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png It used to be white before this patch. REPOSITORY R124 System Settings REVISION DETAIL https://phabric

D26021: Display sub categories when searching

mart updated this revision to Diff 71776. mart added a comment. - get rid of the const cast REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71775&id=71776 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021 AFFEC

D26021: Display sub categories when searching

mart marked 2 inline comments as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SidebarMode.cpp:400 > please check validity, otherwise model is null and we'll crash. > > also ..why make it const, only to cast it? got rif of the cast REPOSITORY R124 System Setting

D26021: Display sub categories when searching

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SidebarMode.cpp:400 > please check validity, otherwise model is null and we'll crash. > > also ..why make it const, only to cast it? QModelIndex::index() is always const? REPOSITORY R124 System Settings REVISION DETAIL

D26021: Display sub categories when searching

mart updated this revision to Diff 71775. mart marked 3 inline comments as done. mart added a comment. - adress comments - fix clicking againthe same category REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71614&id=71775 BRANCH arcpatc

D26021: Display sub categories when searching

davidedmundson added inline comments. INLINE COMMENTS > MenuModel.cpp:102 > +MenuItem *candidate = mi->parent(); > +while ( candidate && candidate->parent() && > candidate->parent()->parent() ) { > +candidate = candidate->parent(); More comments are neede