This revision was automatically updated to reflect the committed changes.
Closed by commit R104:8032881459d1: feat(kded): add orientation sensor
(authored by romangg).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26037?vs=73185=73619
REVISION DETAIL
romangg updated this revision to Diff 73185.
romangg added a comment.
- Fix seg fault on orientation sensor
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26037?vs=73148=73185
BRANCH
orientation-sensor
REVISION DETAIL
romangg updated this revision to Diff 73148.
romangg marked 2 inline comments as done.
romangg added a comment.
- Use connectedToBackend getter
- Replace DeviceOrientation
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26037?vs=73146=73148
BRANCH
romangg updated this revision to Diff 73146.
romangg added a comment.
Rebase on master.
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26037?vs=72352=73146
BRANCH
orientation-sensor
REVISION DETAIL
https://phabricator.kde.org/D26037
AFFECTED FILES
romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in orientation_sensor.cpp:29
> From what I can tell, we can call
>
> if (!sensor->connectToBackend()) {
> m_available = false;
> }
>
> in the constructor
>
> and then we have the option to call start/stop whenever.
Yea, I
davidedmundson added inline comments.
INLINE COMMENTS
> romangg wrote in orientation_sensor.cpp:29
> Yea, we need to start it in the beginning to see if a sensor is available.
> But we could cache the result and then shut it off again in case auto
> rotation or screen is off. Needs some more
romangg updated this revision to Diff 72352.
romangg added a comment.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
- Activate orientation sensor only when used
- Query new libkscreen auto rotation and tablet mode API
REPOSITORY
R104 KScreen
CHANGES SINCE LAST
romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in orientation_sensor.h:38
> I suspect some apps will need that info, but it's just as easy for them to
> get that via QSensors directly.
Looking at it again I don't think it is advisable to remove these two values
from the
