D26068: [KCM/Activity] Use KConfigXT to store settings

meven added inline comments. INLINE COMMENTS > meven wrote in PrivacyTab.cpp:67 > That was not needed, will clean up D26287 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin, crossi Cc:

D26068: [KCM/Activity] Use KConfigXT to store settings

meven added inline comments. INLINE COMMENTS > davidedmundson wrote in PrivacyTab.cpp:67 > Why do we explicitly call deleteLater on these? That was not needed, will clean up REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin,

D26068: [KCM/Activity] Use KConfigXT to store settings

davidedmundson added inline comments. INLINE COMMENTS > PrivacyTab.cpp:67 > +{ > +mainConfig->deleteLater(); > +pluginConfig->deleteLater(); Why do we explicitly call deleteLater on these? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26068: [KCM/Activity] Use KConfigXT to store settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:df0a276b7eea: [KCM/Activity] Use KConfigXT to store settings (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=72093=72369

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 72093. meven marked 3 inline comments as done. meven added a comment. Fix position of * REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=72091=72093 BRANCH arcpatch-D26068 REVISION DETAIL

D26068: [KCM/Activity] Use KConfigXT to store settings

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PrivacyTab.cpp:57 > > -Private() > -: viewBlacklistedApplicationsRoot(nullptr) > +Private(QObject* parent) > +: mainConfig(new

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 72091. meven added a comment. Fix * position REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=72089=72091 BRANCH arcpatch-D26068 REVISION DETAIL https://phabricator.kde.org/D26068 AFFECTED FILES

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 72089. meven added a comment. Make pluginConfig and mainConfig pointers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=71729=72089 BRANCH arcpatch-D26068 REVISION DETAIL

D26068: [KCM/Activity] Use KConfigXT to store settings

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Oops, selected wrong state :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin, crossi Cc: plasma-devel, LeGast00n,

D26068: [KCM/Activity] Use KConfigXT to store settings

ervin accepted this revision. ervin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > PrivacyTab.cpp:50 > public: > -KSharedConfig::Ptr mainConfig; > -KSharedConfig::Ptr pluginConfig; > +KActivityManagerdSettings mainConfig; > +

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 71729. meven added a comment. Ensure the black list opt-in checkbox change apply button state REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=71728=71729 BRANCH activity_kcm REVISION DETAIL

D26068: [KCM/Activity] Use KConfigXT to store settings

meven created this revision. meven added reviewers: Plasma, ervin, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN kcmshell5 kcm_activities Changed settings, restored defaults REPOSITORY R119 Plasma Desktop