D26093: Use a fixed icon size for the notification popup close button

broulik added a comment. F7826451: Screenshot_20191220_095532.png The icon looks pretty big here now - wouldn't it be `small` for normal `ToolButton` icon? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26093 To:

D26093: Use a fixed icon size for the notification popup close button

This revision was automatically updated to reflect the committed changes. Closed by commit R120:66aaaf72a4df: Use a fixed icon size for the notification popup close button (authored by ahiemstra). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26093: Use a fixed icon size for the notification popup close button

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Actually, it not even an optical illusion. It turns out it's because my laptop screen just low quality :( Sorry for all the fuss REPOSITORY R120 Plasma Workspace BRANCH

D26093: Use a fixed icon size for the notification popup close button

ndavis added a comment. It may just be an optical illusion. Sometimes red next to blue or another highly saturated color will appear to be 1px higher than it actually is. Here's a white icon: F7824663: Screenshot_20191218_191906.png REPOSITORY R120

D26093: Use a fixed icon size for the notification popup close button

ndavis added a comment. I do think the larger close icon looks nicer and more in line with window decorations: F7824629: Screenshot_20191218_182922.png The offset is still there, unfortunately. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26093: Use a fixed icon size for the notification popup close button

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Both the popup header size as well as units.smallMargin depend on font size. This causes