D26121: Kicker/RecentDocument display file path as decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9099652598fa: Kicker/RecentDocument display file path as decoration (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26121: Kicker/RecentDocument display file path as decoration

meven added a comment. In D26121#583212 , @ervin wrote: > LGTM, might need an update if D26122 lands though. No need to update here after D26122 , the code uses

D26121: Kicker/RecentDocument display file path as decoration

ervin accepted this revision. ervin added a comment. LGTM, might need an update if D26122 lands though. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26121 REVISION DETAIL https://phabricator.kde.org/D26121 To: meven, #vdg, #plasma, ngraham,

D26121: Kicker/RecentDocument display file path as decoration

meven added a comment. This was done to match my proposed recentlyused krunner : D26111 And the computer should be good now : D26147 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26121 REVISION DETAIL

D26121: Kicker/RecentDocument display file path as decoration

meven added a comment. In D26121#581070 , @ngraham wrote: > Nice, I think this makes sense. Now Kickoff's Computer tab needs the same treatment or else the paths are oddly inconsistent. In another diff, the patch is very simple : D26147

D26121: Kicker/RecentDocument display file path as decoration

ngraham added a comment. Nice, I think this makes sense. Now Kickoff's Computer tab needs the same treatment or else the paths are oddly inconsistent. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26121 REVISION DETAIL https://phabricator.kde.org/D26121 To: meven, #vdg, #plasma,

D26121: Kicker/RecentDocument display file path as decoration

meven updated this revision to Diff 71950. meven added a comment. Use KFilePlacesModel to improve display of history REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71893=71950 BRANCH arcpatch-D26121 REVISION DETAIL

D26121: Kicker/RecentDocument display file path as decoration

ngraham added a comment. Yeah, I think that makes a lot of sense. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26121 To: meven, #vdg, #plasma, ngraham, ervin Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26121: Kicker/RecentDocument display file path as decoration

meven marked an inline comment as done. meven added a comment. In D26121#580666 , @ngraham wrote: > Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided: > > F7826930:

D26121: Kicker/RecentDocument display file path as decoration

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in recentusagemodel.cpp:365 > Probably worth just doing this in a single line rather than defining a > variable used only once I did this for readability, I think we should keep this. The

D26121: Kicker/RecentDocument display file path as decoration

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Actually I see that other list items on other tabs already have path captions like this, so it's not a newly-introduced issue. INLINE COMMENTS > recentusagemodel.cpp:365 > +

D26121: Kicker/RecentDocument display file path as decoration

davidre added a comment. In D26121#580666 , @ngraham wrote: > Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided: > > F7826930: Screenshot_20191220_100525.png

D26121: Kicker/RecentDocument display file path as decoration

ngraham added a comment. Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided: F7826930: Screenshot_20191220_100525.png Not a -1, but I wonder how useful this will be in practice. However big

D26121: Kicker/RecentDocument display file path as decoration

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > meven wrote in recentusagemodel.cpp:269 > I am thinking about adding this utility feature to KCoreAddons and avoid more > duplication. https://phabricator.kde.org/D26122 REPOSITORY R120 Plasma Workspace

D26121: Kicker/RecentDocument display file path as decoration

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > broulik wrote in recentusagemodel.cpp:269 > Can you use the "~" for HOME like the runners do please I am thinking about adding this utility feature to KCoreAddons and avoid more duplication. REPOSITORY

D26121: Kicker/RecentDocument display file path as decoration

meven updated this revision to Diff 71893. meven added a comment. Replace homePath by '~' REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71892=71893 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26121 AFFECTED FILES

D26121: Kicker/RecentDocument display file path as decoration

broulik added inline comments. INLINE COMMENTS > recentusagemodel.cpp:269 > +QString desc = fileItem.localPath(); > +desc.truncate(desc.lastIndexOf(QChar('/'))); > +return desc; Can you use the "~" for HOME like the runners do please REPOSITORY R120 Plasma Workspace

D26121: Kicker/RecentDocument display file path as decoration

meven updated this revision to Diff 71892. meven added a comment. Correct case REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71891=71892 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26121 AFFECTED FILES

D26121: Kicker/RecentDocument display file path as decoration

meven created this revision. meven added reviewers: VDG, Plasma, ngraham, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Also add an open containing folder action REPOSITORY R120 Plasma Workspace