ndavis updated this revision to Diff 72277.
ndavis added a comment.
- Change newFrameRadius to newPenWidthFrameRadius
This name doesn't sound very good, but at least it's more descriptive.
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26225?vs=72185&id=
hpereiradacosta added inline comments.
INLINE COMMENTS
> breezehelper.h:318
> +//* frame radius with new pen width
> +constexpr qreal newFrameRadius ( const qreal oldRadius, const int
> penWidth ) const
> +{ return qMax( oldRadius - (0.5 * penWidth), 0.0 ); }
Would need
ndavis updated this revision to Diff 72185.
ndavis added a comment.
Add default value to frameRadius penWidth
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26225?vs=72184&id=72185
BRANCH
replace-hardcoded-2 (branched from master)
REVISION DETAIL
https:
ndavis created this revision.
ndavis added reviewers: Breeze, Plasma, hpereiradacosta, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.
REVISION SUMMARY
This patch reduces the amount of duplicate code and makes every part
