D26256: [WIP][Applet] Make 'raise maximum volume' global

2020-01-04 Thread George Vogiatzis
gvgeo updated this revision to Diff 72740. gvgeo added a comment. Moved limit max volume, code part,from listbase.qml into the main.qml checkbox. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72295&id=72740 BRANCH raise (bra

D26256: [WIP][Applet] Make 'raise maximum volume' global

2019-12-28 Thread George Vogiatzis
gvgeo added a comment. Actually I never touch volume control, so don't have strong opinion. Either way I'm good, no worries. But in general believe, that should simplify UI and usability, while trying to keep features. This patch removes 2 options. While the other could have the mock

D26256: [WIP][Applet] Make 'raise maximum volume' global

2019-12-28 Thread Nathaniel Graham
ngraham added reviewers: VDG, Plasma, drosca. ngraham added a subscriber: drosca. ngraham added a comment. Thanks for this patch. I won't try to make you go forward with something you don't agree with, so let's continue the discussion here and hopefully we can reach a consensus of some sort.

D26256: [WIP][Applet] Make 'raise maximum volume' global

2019-12-28 Thread George Vogiatzis
gvgeo updated this revision to Diff 72295. gvgeo added a comment. Fixed shortcut keys. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72293&id=72295 BRANCH global (branched from master) REVISION DETAIL https://phabricator.k

D26256: [WIP][Applet] Make 'raise maximum volume' global

2019-12-28 Thread George Vogiatzis
gvgeo added a comment. Have a problem that marked with a TODO comment in code, but the desired functionality is working. @ngraham I should mention that I still oppose to the functionality of this patch, and I believe the better way is D26234 that maybe

D26256: [WIP][Applet] Make 'raise maximum volume' global

2019-12-28 Thread George Vogiatzis
gvgeo created this revision. gvgeo added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Remove maximum volume control from configuration. Remove individual maximum volume. Add a checkbox