This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec73805eb2bf: [KCM/Activities] Use KConfigXT in ui
(authored by meven).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=73063&id=73977
REVISION DETA
meven updated this revision to Diff 73063.
meven added a comment.
Only once commit
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=73062&id=73063
BRANCH
arcpatch-D26398
REVISION DETAIL
https://phabricator.kde.org/D26398
AFFECTED FILES
meven updated this revision to Diff 73062.
meven marked an inline comment as done.
meven added a comment.
Add Q_ASSERTs
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=73056&id=73062
BRANCH
arcpatch-D26398
REVISION DETAIL
https://phabri
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> BlacklistedApplicationsModel.cpp:191
> +emit
> changed(d->pluginConfig->findItem("blockedApplications")->isSaveNeeded() &&
> d->pluginConfig->findItem("all
meven updated this revision to Diff 73056.
meven marked 2 inline comments as done.
meven added a comment.
Improve signals naming, and remove redundant ones
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=73055&id=73056
BRANCH
arcpatch-D263
meven updated this revision to Diff 73055.
meven marked 2 inline comments as done.
meven added a comment.
In BlackListModel only acces concerned items isSaveNeeded and isDefault
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=73054&id=73055
meven updated this revision to Diff 73054.
meven marked 2 inline comments as done.
meven added a comment.
Review, code style
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=72964&id=73054
BRANCH
arcpatch-D26398
REVISION DETAIL
https://p
meven added inline comments.
INLINE COMMENTS
> ervin wrote in BlacklistedApplicationsModel.cpp:179
> I personally like that construct, but AFAIK it's rather unusual in KDE code,
> so maybe for the sake of the future developer use something more "classic".
> Either:
>
> const auto name = d->ap
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
A few changes needed to make the code easier to understand in a few months
time. Also there's a larger concern of a piece of code being prone to later
bugs (although I'd expect it t
meven updated this revision to Diff 72964.
meven added a comment.
Handle BlacklistedApplicationsModel properly, prevent a warning 'duplicate
connection name'
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=72850&id=72964
BRANCH
arcpatch-D
meven updated this revision to Diff 72850.
meven added a comment.
Remove unwanted change
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=72849&id=72850
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26398
AFFECTED FILES
k
meven updated this revision to Diff 72849.
meven added a comment.
KCM/Component clean unused file
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26398?vs=72695&id=72849
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26398
AFFECTED
meven created this revision.
meven added reviewers: Plasma, ervin, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REVISION SUMMARY
Port the ui components to use KConfig XT features to reduce amount of
boilerplate code.
T
13 matches
Mail list logo