broulik added a comment.
Would be lovely in the future to cache those items and make it a proper model
with backing data rather than requesting everything on demand every time `data`
is called.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26416
To: meve
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1640e9f46ef6: Kicker/Documents optimization: Lazily build
KFileItem (authored by meven).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26416?vs=72761&id=7
meven updated this revision to Diff 72761.
meven added a comment.
Remove outdate ifdef, we depend on KF5 5.62
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26416?vs=72735&id=72761
BRANCH
arcpatch-D26416
REVISION DETAIL
https://phabricator.kd
apol added inline comments.
INLINE COMMENTS
> recentusagemodel.cpp:251
> +auto getFileItem = [=] () {
> +#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0)
> +// Avoid calling QT_LSTAT and accessing recent documents
I'm pretty sure we can/should depend on newer KF5. I'd say just
meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REVISION SUMMARY
Save quite a few KFileItem instanciation.
On each document hovering several KFileItem were instanc
