D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

2020-04-14 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. krunner also has horrible file watcher. This either makes sense at a library level (krunner) or in the frontend (krunner) but milou somewhere in the midd

D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

2020-01-07 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > runnerresultsmodel.cpp:189 > + > +m_manager->reloadConfiguration(); > +} This reloads the configuration in `RunnerManager`, so why is this done in `RunnerResultsModel`? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26

D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

2020-01-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This was present in the old `SourcesModel` but not ported to the new one. TEST PLAN 5.17 Noti