This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8be6fb749ced: [wallpapers/image] Add default XDG
wallpaper locations for slideshow (authored by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26
ngraham added a comment.
Thanks David!
REPOSITORY
R120 Plasma Workspace
BRANCH
add-a-default-wallpaper-slideshow-location (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26483
To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson,
ngraham updated this revision to Diff 73571.
ngraham marked an inline comment as done.
ngraham added a comment.
Shallow copy instead of deep copy
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26483?vs=73067&id=73571
BRANCH
add-a-default-wallpap
ngraham updated this revision to Diff 73572.
ngraham added a comment.
Rebase
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26483?vs=73571&id=73572
BRANCH
add-a-default-wallpaper-slideshow-location (branched from master)
REVISION DETAIL
https
ngraham added inline comments.
INLINE COMMENTS
> davidedmundson wrote in image.cpp:362
> there's two mistakes that cancel kinda each other out here.
>
> typically, this should be qAsConst(m_slidePaths)
> m_slidePaths here detatches and does a full deep-copy
>
> https://www.dvratil.cz/2015/06/qt
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> image.cpp:362
> +// Replace 'preferred://wallpaperlocations' with real paths
> +for (QString &path : m_slidePaths) {
> +
ngraham added a comment.
Ping.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26483
To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
ngraham added a comment.
Dependent patches have landed, is this okay now?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26483
To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n,
The-Fer
