D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham updated this revision to Diff 73067. ngraham marked an inline comment as done. ngraham added a comment. Don't auto-append paths when the paths list is empty REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26483?vs=73023=73067 BRANCH

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidre added inline comments. INLINE COMMENTS > image.cpp:366 > if (m_slidePaths.isEmpty()) { > -m_slidePaths << > QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, > QStringLiteral("share/wallpapers"), QStandardPaths::LocateDirectory); > +m_slidePaths <<

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham updated this revision to Diff 73023. ngraham added a comment. Add a `preferred://wallpaperlocations` token and replace it with the real values REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26483?vs=72941=73023 BRANCH

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidedmundson added a comment. Sure REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham added a comment. In D26483#589401 , @broulik wrote: > Perhaps we could leverage some code from Task Manager to have a fake `preferred://wallpaperlocation` URL or something like that? That might be able to work. @davidedmundson,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidedmundson added a comment. I don't think so, as we use a runtime evaluation of kcfg files within plasma. Code tags won't work there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidre added a comment. Couldn't we just use wrap the folders from the single image case in a code tag? `QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("wallpapers/"), QStandardPaths::LocateDirectory)` REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

broulik added a comment. Perhaps we could leverage some code from Task Manager to have a fake `preferred://wallpaperlocation` URL or something like that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. It's not ok for the reasons you identified. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham added a comment. Wondering if this is something that should be set in CMake or if it's so universal that it's okay to have it hardcoded in the file like this? REPOSITORY R120 Plasma Workspace BRANCH add-a-default-wallpaper-slideshow-location (branched from master) REVISION

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH add-a-default-wallpaper-slideshow-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 415461 FIXED-IN: 5.18.0 Right now when you first change the wallpaper plugin to