This revision was automatically updated to reflect the committed changes.
Closed by commit R112:7a6b1a037e65: Use qmlRegisterAnonymousType (authored by
tcanabrava).
REPOSITORY
R112 Milou
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26489?vs=73276=73278
REVISION DETAIL
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Thanks
REPOSITORY
R112 Milou
BRANCH
arcpatch-D26489
REVISION DETAIL
https://phabricator.kde.org/D26489
To: tcanabrava, broulik
Cc: meven, broulik, plasma-devel, LeGast00n,
tcanabrava updated this revision to Diff 73276.
tcanabrava added a comment.
- Move typeRegistration to the Plugin instanciation
REPOSITORY
R112 Milou
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26489?vs=72962=73276
BRANCH
arcpatch-D26489
REVISION DETAIL
meven added inline comments.
INLINE COMMENTS
> draghelper.cpp:32
> {
> -qmlRegisterType("org.kde.milou", 1, 0, "MimeData");
> + qmlRegisterAnonymousType("org.kde.milou", 1);
> }
indentation
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D26489
To: tcanabrava,
broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.
needs a qt version `ifdef`
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D26489
To: tcanabrava, broulik
Cc: broulik, plasma-devel, LeGast00n,
tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.
REPOSITORY
R112 Milou
BRANCH
useQmlRegisterAnonymousType
REVISION DETAIL
https://phabricator.kde.org/D26489
AFFECTED FILES
