This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6a6b94ba7377: Runner/Windows make the window finding more
reliable (authored by meven).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
meven updated this revision to Diff 74155.
meven added a comment.
typo
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26494?vs=74154=74155
BRANCH
arcpatch-D26494
REVISION DETAIL
https://phabricator.kde.org/D26494
AFFECTED FILES
meven updated this revision to Diff 74154.
meven added a comment.
Remove variable m_ready
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26494?vs=74152=74154
BRANCH
arcpatch-D26494
REVISION DETAIL
https://phabricator.kde.org/D26494
AFFECTED
meven updated this revision to Diff 74152.
meven added a comment.
prepareForMatchSession will lock the lock, allowing only gatherInfo to run
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26494?vs=72976=74152
BRANCH
arcpatch-D26494
REVISION
davidedmundson added a comment.
or manually lock in prepareForMatchSession manually unlock in gatherInfo
then you don't need m_ready
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26494
To: meven, #plasma, ngraham, mart, davidedmundson
Cc:
davidedmundson added a comment.
I assume it was done like this, because after you've done
prepareForMatchSession on every runner we can start all the threads and run
match.
If we block the main thread now, it doesn't matter as at least every runner
is busy doing something and the main
broulik added a comment.
Sorry, I don't know how any of that prepare and teardown stuff works, so I
can't really judge.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26494
To: meven, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n,
meven added a comment.
ping @broulik
https://bugs.kde.org/show_bug.cgi?id=414804
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26494
To: meven, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
meven added a comment.
Instead we might want to keep a cache of windows and desktopNames and use
KWindowSystem::desktopNamesChanged and windowAdded / windowRemoved signals.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26494
To: meven, #plasma, ngraham,
meven created this revision.
meven added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REVISION SUMMARY
Call gatherInfo immediately after prepareForMatchSession
QTimer::singleShot could dispatched
10 matches
Mail list logo