D26583: [Application Style] Add GTK Application Style Page

zzag added inline comments. INLINE COMMENTS > gikari wrote in gtkthemesmodel.h:36 > No purpose, therefore can I just delete it? Yes, I don't see why one would want `~Class() override = default` in a header file. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2

D26583: [Application Style] Add GTK Application Style Page

gikari added inline comments. INLINE COMMENTS > zzag wrote in gtkthemesmodel.h:36 > Whar's the purpose of this destructor? No purpose, therefore can I just delete it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26583 To: gikari, #vdg, broulik, #plasma, ngra

D26583: [Application Style] Add GTK Application Style Page

zzag added inline comments. INLINE COMMENTS > gtkthemesmodel.h:36 > +GtkThemesModel(QObject *parent = nullptr); > +~GtkThemesModel() override = default; > + Whar's the purpose of this destructor? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26583 To:

D26583: [Application Style] Add GTK Application Style Page

This revision was automatically updated to reflect the committed changes. Closed by commit R119:268c5ced8ec2: [Application Style] Add GTK Application Style Page (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73536&id=73624

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73536. gikari added a comment. Return accidentally removed empty lines in `kcmstyle.h` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73534&id=73536 BRANCH gtk-style-page REVISION DETAIL https://pha

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73534. gikari marked 3 inline comments as done. gikari added a comment. Remove `columnCount` method and fix `rowCount` method REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73519&id=73534 BRANCH gtk-st

D26583: [Application Style] Add GTK Application Style Page

gikari added inline comments. INLINE COMMENTS > davidedmundson wrote in gtkthemesmodel.cpp:107 > this needs to be > > if (parent.isValid()) { > return m_themesList.count(); > } > return 0; > > Otherwise your're saying every item has children with N rows, which have > children with N rows forev

D26583: [Application Style] Add GTK Application Style Page

broulik added inline comments. INLINE COMMENTS > gikari wrote in gtkthemesmodel.cpp:107 > Did you mean > > if (parent.isValid()) { > return 0; > } > return m_themesList.count(); > > ? I think so :D REPOSITORY R119 Plasma Desktop BRANCH gtk-style-page REVISION DETAIL https:

D26583: [Application Style] Add GTK Application Style Page

davidedmundson added inline comments. INLINE COMMENTS > gtkthemesmodel.cpp:107 > +int GtkThemesModel::rowCount(const QModelIndex& parent) const > +{ > +Q_UNUSED(parent) this needs to be if (parent.isValid()) { return m_themesList.count(); } return 0; Otherwise your're saying every item has

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73519. gikari added a comment. Remove Q_SLOT keyword from `load` and add override to destructor REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73429&id=73519 BRANCH gtk-style-page REVISION DETAIL ht

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73429. gikari added a comment. Replace themeUpdate redundant signal with direct load call. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73425&id=73429 BRANCH gtk-style-page REVISION DETAIL https:/

D26583: [Application Style] Add GTK Application Style Page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Visually and behaviorally, this is great. Probably needs a #plasma review too. REPOSITORY R119 Plasma Desktop BRANCH gtk-style-page REVISIO

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73425. gikari added a comment. Undo previous hasty decision REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73390&id=73425 BRANCH gtk-style-page REVISION DETAIL https://phabricator.kde.org/D26583 AF

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73390. gikari added a comment. Replace `include gtkpage` with forward declaration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73313&id=73390 BRANCH gtk-style-page REVISION DETAIL https://phabrica

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73313. gikari added a comment. Remove unnessary include and `containsTheme` function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73272&id=73313 BRANCH gtk-style-page REVISION DETAIL https://phabr

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73272. gikari edited the test plan for this revision. gikari added a comment. Do not init `GtkPage*`, if the kded module is not loaded REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73271&id=73272 BRANCH

D26583: [Application Style] Add GTK Application Style Page

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY The GTK KCM is now moved to Application Style KCM as a sub page. The functionality is identical to the one, found in GTK KCM, as wel