D26587: [GTK3] Improve Electron menubar legibility

ndavis added a comment. In D26587#592088 , @broulik wrote: > Hmm this makes inactive tabs even harder to spot than already :/ There's really not much we can do about Chromium when every Electron app uses the custom CSS we have for

D26587: [GTK3] Improve Electron menubar legibility

broulik added a comment. Hmm this makes inactive tabs even harder to spot than already :/ REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D26587 To: cblack, #vdg, #breeze, ndavis Cc: broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26587: [GTK3] Improve Electron menubar legibility

This revision was automatically updated to reflect the committed changes. Closed by commit R98:c9ac507ff3c2: [GTK3] Improve Electron menubar legibility (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26587?vs=73287=73288 REVISION

D26587: [GTK3] Improve Electron menubar legibility

cblack updated this revision to Diff 73287. cblack added a comment. Remove commented line REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26587?vs=73286=73287 BRANCH electron-menubar-fix (branched from master) REVISION DETAIL

D26587: [GTK3] Improve Electron menubar legibility

ndavis added inline comments. INLINE COMMENTS > _chromium.scss:6 > +color: gtk("@theme_titlebar_foreground"); > +// color: gtk("@theme_titlebar_foreground_backdrop"); — This makes > Chromium look good but impairs legibility in electron menubars > background-color:

D26587: [GTK3] Improve Electron menubar legibility

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think this is fine. REPOSITORY R98 Breeze for Gtk BRANCH electron-menubar-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D26587 To: cblack, #vdg, #breeze,

D26587: [GTK3] Improve Electron menubar legibility

cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Electron apps using a menubar are now more legible. This has the side effect of forcing background tabs in Chrome/ium to not have