D2660: Prefer an algorithm over an explicit for loop

2017-11-15 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R122:d492dc57eeb3: Prefer an algorithm over an explicit for loop (authored by jkt, committed by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2660?vs=7144=22397#toc REPOSITORY

[Differential] [Updated, 9 lines] D2660: Prefer an algorithm over an explicit for loop

2016-10-06 Thread Jan Kundrát
jkt removed rPOWERDEVIL Powerdevil as the repository for this revision. jkt updated this revision to Diff 7144. jkt added a comment. I used cbegin because this is in a place which uses STL idioms. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2660?vs=6435=7144 REVISION DETAIL

[Differential] [Accepted] D2660: Prefer an algorithm over an explicit for loop

2016-10-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. you can make them constBegin() now you're doing the clear after? REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL

[Differential] [Commented On] D2660: Prefer an algorithm over an explicit for loop

2016-10-06 Thread mart (Marco Martin)
mart added a comment. any news on that? REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2660 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jkt, broulik Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,