D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3e9cd8d1e551: Make checkboxes/radiobuttons use Window Background in windows and View… (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26639?vs=734

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. In D26639#593537 , @ndavis wrote: > In D26572#593511 , @hpereiradacosta wrote:

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis updated this revision to Diff 73458. ndavis added a comment. Fix formatting REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26639?vs=73457&id=73458 BRANCH checkbox-radiobutton (branched from master) REVISION DETAIL https://phabricator.kde.org/D266

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ngraham accepted this revision as: VDG. ngraham added a comment. Visually +1, fixes the minor background color bug that came from the last commit. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26639 To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham Cc: plasma-deve

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis added a comment. After this patch, should I remove `isSelectedItem()`? It's currently unused. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26639 To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachu

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis added a comment. In D26572#593511 , @hpereiradacosta wrote: > > Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases. > > This would lead to some regression (I think) for unchecke

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REPOSITORY R31 Breeze BRANCH checkbox-radiobutton (branched from master) REVISION DETAIL https://phabricator