D26654: support mobile mode scrollbar

This revision was automatically updated to reflect the committed changes. Closed by commit R858:471213f74a40: support mobile mode scrollbar (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26654?vs=73626=73627

D26654: support mobile mode scrollbar

mart updated this revision to Diff 73626. mart added a comment. - Merge branch 'master' into phab/mobilescrollbar - consider the frame paddings for the scrollbar REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D26654: support mobile mode scrollbar

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. Seems like that's a local issue actually. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH phab/mobilescrollbar REVISION DETAIL

D26654: support mobile mode scrollbar

ngraham added a comment. Very nice! Overall it works very well. I found a few issues in QML KCMs: F7883084: Regression: Notifications KCM.jpg F7883085: Regression: Desktop Effects KCM.jpg REPOSITORY

D26654: support mobile mode scrollbar

mart updated this revision to Diff 73542. mart added a comment. - smoother transition REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26654?vs=73507=73542 BRANCH phab/mobilescrollbar REVISION DETAIL

D26654: support mobile mode scrollbar

mart updated this revision to Diff 73507. mart added a comment. - support also horizontal scrollbars REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26654?vs=73502=73507 BRANCH phab/mobilescrollbar REVISION DETAIL

D26654: support mobile mode scrollbar

mart marked an inline comment as done. mart added a comment. screenshots done with also D26655 in REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26654 To: mart, #plasma, #vdg, #kirigami Cc: broulik,

D26654: support mobile mode scrollbar

broulik added a comment. Cool! The width change during the slide animation looks a bit odd, though INLINE COMMENTS > ScrollBar.qml:50 > +id: handleGraphics > +x: scrolling ? parent.width/2 - width/2 : parent.width - width > + `Math.round` REPOSITORY R858 Qt Quick

D26654: support mobile mode scrollbar

mart created this revision. mart added reviewers: Plasma, VDG, Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when on mobile (or just "tabletmode" the scrollbar goes to "not interactive" in that case