D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

davidedmundson added a comment. > So you oppose preloading of KRunner service, but accept it continuing to run forever awaiting its next use. I don't find this consistent. It's a common lazy-load pattern. Though that extension of closing down would also be a direction I would happily

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595756 , @davidedmundson wrote: > I don't want us to make krunner autostart. It's a hack, not a fix. I'm gonna play devil's advocate here :) If having an already running KRunner service is a hack,

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski planned changes to this revision. pdabrowski added inline comments. INLINE COMMENTS > desktopview.cpp:262 > if (!e->modifiers() || e->modifiers() == Qt::ShiftModifier) { > const QString text = e->text().trimmed(); > if (!text.isEmpty() && text[0].isPrint()) {

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The continual forwarding of keys makes sense. I'm happy to accept that. I don't want us to make krunner autostart. It's a hack, not a fix. REPOSITORY R120

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 73740. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26718?vs=73737=73740 REVISION DETAIL https://phabricator.kde.org/D26718 AFFECTED FILES krunner/CMakeLists.txt

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in main.cpp:231 > This is not how we want to autostart something :) Instead, you want to place > the desktop file in autostart folder again Right :) I thought of this so that everytime Plasma starts it ensures KRunner is running

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595688 , @broulik wrote: > Maybe if we autostarted KRunner based on whether it was used previously "Used previously" as in opened at least once? I guess this is always true for every user, because

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

broulik added a comment. Hmm, I'd appreciate some startup time optimizations for KRunner first. Maybe if we autostarted KRunner based on whether it was used previously would be a nice trade-off between resources for systems that don't use it and power users that always use it and get

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

ngraham added a comment. IIRC we used to do this, but changed it to run-on-demand to save some memory on startup. Might be worth revisiting that though, since I can confirm the latency that leads to the first few characters getting typed into the open app instead of KRunner, which is

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski created this revision. pdabrowski added reviewers: Plasma, Plasma: Workspaces, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY autostart KRunner with Plasma as daemon to