kmaterka marked an inline comment as done.
kmaterka added inline comments.
INLINE COMMENTS
> broulik wrote in systemtraymodel.cpp:269
> Avoid `keys()` which creates a temporary list, instead use iterators
>
> const auto roleNames = sourceModel->roleNames();
> for (auto it =
kmaterka updated this revision to Diff 74272.
kmaterka added a comment.
Iterator used
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26850?vs=74164=74272
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26850
AFFECTED FILES
broulik added inline comments.
INLINE COMMENTS
> systemtraymodel.cpp:269
> +QHash roleNames = sourceModel->roleNames();
> +for (const int key : roleNames.keys()) {
> +if (!m_roleNames.contains(key)) {
Avoid `keys()` which creates a temporary list, instead use iterators
const
kmaterka added a comment.
Problem was in duplicated role names, which confused ListView/delegate.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26850
To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma.
kmaterka added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.
REVISION SUMMARY
Fixes a bug, when system tray settings is opened and new application is
