broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Qt says to do a proper model reset in this method.
I also noticed something funky going on with
davidedmundson added a comment.
QAbstractSortFilterProxyModel has docs that say you need it, but
QSortFilterProxyModel which you inherit from does reset the model in
setSourceModel.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D27037
To: broulik, #plasma
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1c0c8ddef430: [Notifications] Fixup setSourceModel
(authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricato
