This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d28337b6d379: KCM Fonts port anti aliasing part to
KPropertySkeletonItem (authored by bport).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75890&i
meven added a comment.
Seems ready to land
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27156
To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBo
bport updated this revision to Diff 75890.
bport added a comment.
fix build. KRDB can't use Kxftconfig directly so we can't avoid stuff in
kdeglobals
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75844&id=75890
REVISION DETAIL
https://p
bport updated this revision to Diff 75844.
bport added a comment.
Add missing space
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75813&id=75844
REVISION DETAIL
https://phabricator.kde.org/D27156
AFFECTED FILES
kcms/fonts/CMakeLists.t
crossi added inline comments.
INLINE COMMENTS
> fontsaasettings.cpp:305
> +{
> +if(dpi() == newDPI) {
> +return;
add space between `if` and `(` please
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27156
To: bport, #plasma, ervin, crossi, meven
Cc:
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.
Looks good to me now, maybe try to get more reviewers before pushing though.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27156
To: bport, #plasma, ervin,
bport updated this revision to Diff 75813.
bport added a comment.
Add kconfupdate script to remove unused keys
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75541&id=75813
REVISION DETAIL
https://phabricator.kde.org/D27156
AFFECTED FILE
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fonts.cpp:136
> +for (KXftConfig::Hint::Style s : {KXftConfig::Hint::None,
> KXftConfig::Hint::Slight, KXftConfig::Hint::Medium, KXftConfig::Hint::Full}) {
bport updated this revision to Diff 75541.
bport added a comment.
Fix reset and default button for Anti Aliasing area (states were ok, but UI
values were not updated after clicking them)
depends on https://phabricator.kde.org/D27342
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UP
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fonts.cpp:131
> +for (int t = KXftConfig::SubPixel::None; t <=
> KXftConfig::SubPixel::Vbgr; ++t) {
> +QStandardItem *item = new
> QStandardItem(KX
bport added inline comments.
INLINE COMMENTS
> usta wrote in main.qml:242
> I am really away from qml thing but are you sure this one correct ? I mean
> isnt this should be
> kcm.dpi instead of kcm.fontsAASettings.dpi ??
No dpi is declared inside fontsAASettings
REPOSITORY
R119 Plasma Deskt
usta added inline comments.
INLINE COMMENTS
> main.qml:242
> id: dpiCheckBox
> -checked: kcm.fontAASettings.dpi !== 0
> +checked: kcm.fontsAASettings.dpi !== 0
> text: i18n("Force font DPI:")
I am really away from
bport updated this revision to Diff 75465.
bport added a comment.
fix coding style
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75446&id=75465
REVISION DETAIL
https://phabricator.kde.org/D27156
AFFECTED FILES
kcms/fonts/CMakeLists.tx
bport updated this revision to Diff 75446.
bport added a comment.
coding style
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75444&id=75446
REVISION DETAIL
https://phabricator.kde.org/D27156
AFFECTED FILES
kcms/fonts/CMakeLists.txt
bport updated this revision to Diff 75444.
bport added a comment.
Fix
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75442&id=75444
REVISION DETAIL
https://phabricator.kde.org/D27156
AFFECTED FILES
kcms/fonts/CMakeLists.txt
kcms/font
bport updated this revision to Diff 75442.
bport added a comment.
Take in consideration Cyril's feedbacks
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27156?vs=75000&id=75442
REVISION DETAIL
https://phabricator.kde.org/D27156
AFFECTED FILES
k
crossi added inline comments.
INLINE COMMENTS
> fonts.cpp:201
> +Q_ASSERT(dpiItem && dpiWaylandItem && antiAliasingItem);
> +if (dpiItem->isSaveNeeded() || dpiWaylandItem->isSaveNeeded() ||
> antiAliasingItem) {
> +emit aliasingChangeApplied();
antiAliasingItem->isSaveNeeded() ?
bport created this revision.
bport added reviewers: Plasma, ervin, crossi, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27156
AFFECTED FILES
18 matches
Mail list logo
