D27325: improve some previously recycled strings

2020-02-12 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R102:e0268dc8032c: improve some previously recycled strings (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27325?vs=75478&id=75545#toc REPOSITORY R102 KInfoCenter CHANGES S

D27325: improve some previously recycled strings

2020-02-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In that case, with kio-fuse, "Mounted shares" is probably more accurate and just fine. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D27325

D27325: improve some previously recycled strings

2020-02-11 Thread Harald Sitter
sitter added a comment. That may be misleading expectations I fear. When you browse smb:// in dolphin you'd be accessing shares, but they'd not appear in that list ;) REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27325 To: sitter, ngraham Cc: plasma-devel, Ora

D27325: improve some previously recycled strings

2020-02-11 Thread Nathaniel Graham
ngraham added a comment. "Accessed shares"? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27325 To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himces

D27325: improve some previously recycled strings

2020-02-11 Thread Harald Sitter
sitter added a comment. I do wonder if "Mounted Shares" is all that grand. Technically they may not be mounted but mountable. E.g. when you put a mount into /etc/fstab it will be listed here but not necessarily mounted. Another question is if someone has better suggestions for the column

D27325: improve some previously recycled strings

2020-02-11 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY for 5.18 we recycled these to reduce the new strings, for 5.19 we want something more approachable