apol added a comment.
Here's an alternative https://phabricator.kde.org/D27346
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27337
To: Zren, apol, #plasma
Cc: broulik, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n,
The-Feren-OS-Dev, cblack,
apol added inline comments.
INLINE COMMENTS
> broulik wrote in CategoryPage.qml:71
> > but there was a bit of an empty space on the right.
>
> If `Label` resizing is the problem. Would keeping the `Label` square and
> using a padding `Item` around it fix the performance issue?
Yes, or just
broulik added inline comments.
INLINE COMMENTS
> apol wrote in CategoryPage.qml:71
> This was added so that the columns adapt to the width of the view, otherwise
> it was very fast (as fast as without your Loader) but there was a bit of an
> empty space on the right.
> but there was a bit of
apol added inline comments.
INLINE COMMENTS
> CategoryPage.qml:71
>
> -cellWidth: width/columnsToHave
> +cellWidth: desiredSize
> cellHeight: desiredSize
This was added so that the columns adapt to the width of the view, otherwise it
was very fast (as fast as without
apol added a comment.
Right, maybe we can find a better way of doing this. Or just delaying
resizing of the Label since it's indeed the slow part.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27337
To: Zren, apol, #plasma
Cc: broulik, davidedmundson,
Zren added a comment.
I used `Loader` as I didn't want loading glyphs to block scrollbar
responsiveness. `GridView` reuses delegates, but I don't think it's the
`MouseArea` + `Label` constructor that's slow. I think it's the "rendering the
emoji glyph" in the GUI draw that is the root
broulik added a comment.
I suspect `DelegateRecycler` doesn't do grid, otherwise this could have been
an option?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27337
To: Zren, apol, #plasma
Cc: broulik, davidedmundson, ngraham, plasma-devel, Orage,
davidedmundson added a comment.
What the original code was trying to do was distribute the whitespace among
cells, right now if you resize to be 5.8 columns wide we want to spread that
out, not have a gap on the white.
You're right on the fonts resizing though.
This is also a fix:
davidedmundson added a comment.
Delegates are already async loaded. What does nesting a loader provide on top?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27337
To: Zren, apol, #plasma
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n,
ngraham added reviewers: apol, Plasma.
ngraham added a comment.
Very nice.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27337
To: Zren, apol, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas,
Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.
REVISION SUMMARY
BUG: 417454
The emojier fairly slow. Launching is slow. Resizing the window is slow.
Changing pages is slow. Scrolling is also
11 matches
Mail list logo
