D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

2020-02-13 Thread Arjen Hiemstra
ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. I agree with what @cfeck says. I can also already think of at least one case where even a 256KiB buffer would be too small, which is a dual-cpu Epyc system, where you can

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

2020-02-13 Thread Jakob Kummerow
jakobkummerow added a comment. cfeck: Sure, an even better long-term fix would be to stop depending on a hard-coded buffer size. Interleaved reading and parsing would be one way to achieve that; another way would be a dynamic buffer size: start small, and if it's too small then allocate a

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

2020-02-13 Thread Christoph Feck
cfeck added a comment. From that bug report: Newer x86_64 kernels, however, allow up to 4096 CPUs, so either the buffer needs to be much bigger, or we should do interleaved /proc/cpuinfo reading and parsing. REPOSITORY R106 KSysguard REVISION DETAIL

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

2020-02-13 Thread Jakob Kummerow
jakobkummerow created this revision. jakobkummerow added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jakobkummerow requested review of this revision. REVISION SUMMARY Getting CPU information starts with reading /proc/cpuinfo into a