D27422: [KCM]Always allow port selection

2020-02-16 Thread George Vogiatzis
gvgeo updated this revision to Diff 75760. gvgeo added a comment. Use PC3 and remove unused imports. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75758=75760 BRANCH kcmports2 REVISION DETAIL

D27422: [KCM]Always allow port selection

2020-02-16 Thread George Vogiatzis
gvgeo updated this revision to Diff 75758. gvgeo added a comment. Update Layout REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75743=75758 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED FILES

D27422: [KCM]Always allow port selection

2020-02-15 Thread Nathaniel Graham
ngraham added a comment. In D27422#612019 , @gvgeo wrote: > If default button can leave, personally I would prefer this layout (ignore the margins). > F8105190: Screenshot_20200215_173638.png > And

D27422: [KCM]Always allow port selection

2020-02-15 Thread George Vogiatzis
gvgeo added a reviewer: VDG. gvgeo added a comment. If default button can leave, personally I would prefer this layout (ignore the margins). F8105190: Screenshot_20200215_173638.png And it could help avoid bugs like "applet missing the default

D27422: [KCM]Always allow port selection

2020-02-15 Thread George Vogiatzis
gvgeo created this revision. gvgeo added reviewers: Plasma, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Add extra row for port combobox. Limit combobox's size to fit inside the row. Set