D27422: [KCM]Update Device item layout based on applet

This revision was automatically updated to reflect the committed changes. Closed by commit R115:606c6499750a: [KCM]Update Device item layout based on applet (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76840&i

D27422: [KCM]Update Device item layout based on applet

ngraham accepted this revision. ngraham added a comment. Ship it, the jagginess is clearly caused by something lower in the stack. REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma,

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. In D27422#614236 , @ngraham wrote: > I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: > > F8112849: Screenshot_20200219_075319.png > > T

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76840. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76475&id=76840 BRANCH kcmports3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D274

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76475. gvgeo added a comment. Hide portbox if window is too small. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76093&id=76475 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.o

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76093. gvgeo added a comment. Fix problem 3 REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75971&id=76093 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED FIL

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. > I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: I cannot replicate this. And I cannot see how I could have created this. Or where to start. Here's my short list of problems. F8113183: problems.png

D27422: [KCM]Update Device item layout based on applet

ngraham added a comment. I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: F8112849: Screenshot_20200219_075319.png This is just 1x scaling with no weird font DPI fiddling. REPOSITORY R115 Plasma Audio V

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75971. gvgeo added a comment. Kirigami units. Remove unnecessary preferred width. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75935&id=75971 BRANCH kcmports2 REVISION DETAIL https://

D27422: [KCM]Update Device item layout based on applet

davidedmundson added inline comments. INLINE COMMENTS > DeviceListItem.qml:32 > id: delegate > +spacing: units.smallSpacing * 2 > width: parent.width Kirigami.Units.smallSpacing please (for all units in KCM code) again, for complex reasons, sorry. > DeviceListItem.qml:106 > +

D27422: [KCM]Update Device item layout based on applet

ngraham added a comment. You might be hitting https://bugs.kde.org/show_bug.cgi?id=356446 REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Fe

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. Although this is a general problem, just to be clear. Without Plasma Components I don't get any scaling. F8111566: Screenshot_20200218_214017.png REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75935. gvgeo added a comment. More style fixes. (indentation restore) REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75820&id=75935 BRANCH kcmports2 REVISION DETAIL https://phabricator.kd

D27422: [KCM]Update Device item layout based on applet

ngraham added a comment. You're welcome! REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouk

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. Thanks Nate, both for explaining and taking care of the patches yesterday. REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n

D27422: [KCM]Update Device item layout based on applet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. #plasma folks? In D27422#612797 , @gvgeo wrote: > Remove PlasmaComponents. > > So..

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75820. gvgeo added a comment. Style REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75819&id=75820 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED FILES src

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75819. gvgeo added a comment. Restore imports. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75818&id=75819 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75818. gvgeo added a comment. Remove PlasmaComponents. So.. why all these different distinctions exist? REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75760&id=75818 BRANCH kcmports2 R

D27422: [KCM]Update Device item layout based on applet

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Don't use PlasmaComponents in KCMs; it's for Applets and other elements of the Plasma shell itself. Kirigami is the correct choice for a KCM. REPOSITORY R115 Plasma Audio Volu