D27442: fix(kcm): use explicit Kirigami.Units over singleton from a theme

This revision was automatically updated to reflect the committed changes. Closed by commit R104:357df7c5c48a: fix(kcm): use explicit Kirigami.Units over singleton from a theme (authored by davidedmundson). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27442?v

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

davidedmundson added a comment. > More generally, should we be porting towards Kirigami.Units everywhere? "everywhere" is complex. If it was using the API from kirigami's theme plugin, it should be ported. If it was resolving against the one from PlasmaCore, that's fine. REPOSITORY

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

davidre added a comment. I think the commit message got bit messed up David, pls fix before commiting :) In D27442#612482 , @ngraham wrote: > More generally, should we be porting towards `Kirigami.Units` everywhere? I think plasmoids

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

ngraham added a comment. More generally, should we be porting towards `Kirigami.Units` everywhere? REPOSITORY R104 KScreen BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27442 To: davidedmundson, #plasma, apol Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY units lowercase is defined by PlasmaCore as a singleton (which we genera