D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart added a comment. demo of adding 2 spacers and centering mode F8112648: vokoscreen-2020-02-19_13-43-02.mp4 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vdg Cc: broulik, ngraham, plasm

D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart updated this revision to Diff 75988. mart added a comment. - put the second spacer at the beginning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75980&id=75988 BRANCH mart/panelSpacer REVISION DETAIL https://phabricator.kde.or

D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart updated this revision to Diff 75980. mart marked 3 inline comments as done. mart added a comment. - use a binding - use twinlayouts only when both are expanding REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75925&id=75980 BRANCH

D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > broulik wrote in main.qml:30 > Why that? no idea, is from the old applet and appears useless (also phab gets confused and doesn't understand the move of main.qml to a subfolder) > broulik wrote in main.qml:77 > Does `Qt.callLater(foo)` work? It als

D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.xml:15 > length in pixels of the spacer. Configuration effective only > if expanding is set to false. > +-1 > Please mention in the label what `-1` means > main.qml:30 > + > +z: > +property bool horizonta

D27481: [WIP]Panel spacer that can center things

2020-02-18 Thread Nathaniel Graham
ngraham added a comment. Super cool feature! This was one of the things I was missing for D24223 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27481: [WIP]Panel spacer that can center things

2020-02-18 Thread Marco Martin
mart added a comment. Implementation-wise could make sense for the implementation be in the panel itself, tough it may be difficult to control from the external panel configuration tool Usability-wise i think would be fine if the first spacer is added at the end of the panel, and the se

D27481: [WIP]Panel spacer that can center things

2020-02-18 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY - Make the panel spacer take a lot more space when is in expanding mode, so much to "win" against