This revision was automatically updated to reflect the committed changes.
Closed by commit R111:834de9a585c6: Introduce ProcessDataModel (authored by
davidedmundson).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27509?vs=78091=78346
REVISION
davidedmundson updated this revision to Diff 78091.
davidedmundson added a comment.
cache kuser
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27509?vs=78089=78091
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27509
AFFECTED
davidedmundson updated this revision to Diff 78089.
davidedmundson added a comment.
cache kuser
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27509?vs=78025=78089
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27509
AFFECTED
davidedmundson updated this revision to Diff 78025.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.
lambdas everywhere
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27509?vs=76653=78025
BRANCH
master
REVISION
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in extended_process_list.cpp:394
> This could have used a `reserve` call :)
not a meaningful one, each provider can add provide many attributes
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
davidedmundson updated this revision to Diff 76653.
davidedmundson marked 15 inline comments as done.
davidedmundson added a comment.
some but not all review comments
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27509?vs=76011=76653
BRANCH
ahiemstra added inline comments.
INLINE COMMENTS
> broulik wrote in process_data_model.cpp:278
> Superfluous; or have it return `name()` instead
Oops. Both this one and the one in data() should return name() if shortName()
is empty.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in process_data_model.h:53
> should this just be `Qt::DisplayRole` given you return for both in `data`?
It breaks our roleNames as you can't have two names for the same value.
Then on the QML side we can't interchange with
broulik added inline comments.
INLINE COMMENTS
> extended_process_list.cpp:62
> +if (m_changeFlag != 0) {
> +connect(parent, ::processChanged, this,
> [=](KSysGuard::Process *process) {
> +if (!process->changes().testFlag(m_changeFlag)) {
Capture only
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Last release a plugin system was introduced that allowed plugins to
provide columns of process data in a way that
10 matches
Mail list logo
